Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(thrift): new skipdecoder impl #35

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Nov 29, 2024

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 46 files.

Valid Invalid Ignored Fixed
45 1 0 0
Click to see the invalid file list
  • protocol/thrift/skipdecoder_tpl.go

protocol/thrift/skipdecoder_tpl.go Show resolved Hide resolved
HeyJavaBean
HeyJavaBean previously approved these changes Nov 29, 2024
@xiaost xiaost force-pushed the refactor/new-skipdecoder branch 2 times, most recently from a8a0f94 to 53c243e Compare November 29, 2024 07:25
HeyJavaBean
HeyJavaBean previously approved these changes Nov 29, 2024
DMwangnima
DMwangnima previously approved these changes Nov 29, 2024
@xiaost xiaost dismissed stale reviews from DMwangnima and HeyJavaBean via 403740f November 29, 2024 07:36
@xiaost xiaost force-pushed the refactor/new-skipdecoder branch from 53c243e to 403740f Compare November 29, 2024 07:36
@HeyJavaBean HeyJavaBean merged commit bca2e1a into main Dec 3, 2024
27 checks passed
@xiaost xiaost deleted the refactor/new-skipdecoder branch December 17, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants