Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thrift): add Writer/Reader #2

Merged
merged 4 commits into from
Jul 19, 2024
Merged

feat(thrift): add Writer/Reader #2

merged 4 commits into from
Jul 19, 2024

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Jul 18, 2024

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

thrift 增加 Writer 和 Reader 方法

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • For replacing kitex/pkg/protocol/bthrift and pkg/remote/codec/thrift
  • Also renamed pkg unsafe to hack, coz sometimes still have to use unsafe.Add which is a build-in func.

zh(optional):

  • 用于替换 kitex/pkg/protocol/bthriftpkg/remote/codec/thrift
  • 同时也改名了 库 unsafehack, 因为有时候需要使用 unsafe.Add,但因为其是build-in函数,不能放hack

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@xiaost xiaost requested review from joway and Marina-Sakai July 18, 2024 07:12
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 12 files.

Valid Invalid Ignored Fixed
7 5 0 0
Click to see the invalid file list
  • protocol/thrift/binaryreader.go
  • protocol/thrift/binaryreader_test.go
  • protocol/thrift/binarywriter.go
  • protocol/thrift/binarywriter_test.go
  • protocol/thrift/utils.go

protocol/thrift/binaryreader.go Show resolved Hide resolved
protocol/thrift/binaryreader_test.go Show resolved Hide resolved
protocol/thrift/binarywriter.go Show resolved Hide resolved
protocol/thrift/binarywriter_test.go Show resolved Hide resolved
protocol/thrift/utils.go Show resolved Hide resolved
Marina-Sakai
Marina-Sakai previously approved these changes Jul 18, 2024
joway
joway previously approved these changes Jul 19, 2024
internal/unsafe2/unsafe.go Outdated Show resolved Hide resolved
@xiaost xiaost dismissed stale reviews from joway and Marina-Sakai via 8b69865 July 19, 2024 03:18
@xiaost xiaost merged commit dbcaae7 into develop Jul 19, 2024
14 checks passed
@xiaost xiaost deleted the feat-reader-writer branch July 19, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants