generated from cloudwego/.github
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thrift): add Writer/Reader #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 12 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
7 | 5 | 0 | 0 |
Click to see the invalid file list
- protocol/thrift/binaryreader.go
- protocol/thrift/binaryreader_test.go
- protocol/thrift/binarywriter.go
- protocol/thrift/binarywriter_test.go
- protocol/thrift/utils.go
Marina-Sakai
previously approved these changes
Jul 18, 2024
joway
previously approved these changes
Jul 19, 2024
joway
approved these changes
Jul 19, 2024
Marina-Sakai
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
thrift 增加 Writer 和 Reader 方法
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
kitex/pkg/protocol/bthrift
andpkg/remote/codec/thrift
unsafe
tohack
, coz sometimes still have to useunsafe.Add
which is a build-in func.zh(optional):
kitex/pkg/protocol/bthrift
和pkg/remote/codec/thrift
unsafe
为hack
, 因为有时候需要使用unsafe.Add
,但因为其是build-in函数,不能放hack
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: