refactor(thrift): rm unnecessary args from MessageBeginLength

cloudwego · Jul 31, 2024 · a1bd708 · a1bd708
1 parent c4fad10
commit a1bd708
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/protocol/thrift/binary.go b/protocol/thrift/binary.go
@@ -199,8 +199,8 @@ func appendUint64(buf []byte, v uint64) []byte {
 
 // Length methods
 
-func (BinaryProtocol) MessageBeginLength(name string, _ TMessageType, _ int32) int {
-	return 4 + (4 + len(name)) + 4
+func (BinaryProtocol) MessageBeginLength(method string) int {
+	return 4 + (4 + len(method)) + 4
 }
 
 func (BinaryProtocol) FieldBeginLength() int           { return 3 }

diff --git a/protocol/thrift/binary_test.go b/protocol/thrift/binary_test.go
@@ -188,7 +188,7 @@ func TestBinary(t *testing.T) {
 
 	{ // Message
 		testname, testtyp, testseq := "name", CALL, int32(7)
-		sz := Binary.MessageBeginLength(testname, testtyp, testseq)
+		sz := Binary.MessageBeginLength(testname)
 
 		b := Binary.AppendMessageBegin([]byte(nil), testname, testtyp, testseq)
 		require.Equal(t, int(sz), len(b))

diff --git a/protocol/thrift/fastcodec.go b/protocol/thrift/fastcodec.go
@@ -60,7 +60,7 @@ func MarshalFastMsg(method string, msgType TMessageType, seq int32, msg FastCode
 	if method == "" {
 		return nil, errors.New("method not set")
 	}
-	sz := Binary.MessageBeginLength(method, msgType, seq) + msg.BLength()
+	sz := Binary.MessageBeginLength(method) + msg.BLength()
 	b := dirtmake.Bytes(sz, sz)
 	i := Binary.WriteMessageBegin(b, method, msgType, seq)
 	_ = msg.FastWriteNocopy(b[i:], nil)