fix: fix the NocopyWriteThreshold check logic (#20)

cloudwego · Sep 10, 2024 · 608357f · 608357f
1 parent 024f019
commit 608357f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/protocol/thrift/binary.go b/protocol/thrift/binary.go
@@ -118,7 +118,7 @@ func (BinaryProtocol) WriteBinary(buf, v []byte) int {
 }
 
 func (p BinaryProtocol) WriteBinaryNocopy(buf []byte, w NocopyWriter, v []byte) int {
-	if w == nil || len(buf) < NocopyWriteThreshold {
+	if w == nil || len(v) < nocopyWriteThreshold {
 		return p.WriteBinary(buf, v)
 	}
 	binary.BigEndian.PutUint32(buf, uint32(len(v)))

diff --git a/protocol/thrift/fastcodec.go b/protocol/thrift/fastcodec.go
@@ -22,11 +22,11 @@ import (
 	"github.com/bytedance/gopkg/lang/dirtmake"
 )
 
-// NocopyWriteThreshold represents the threshold of using `NocopyWriter` for binary or string
+// nocopyWriteThreshold represents the threshold of using `NocopyWriter` for binary or string
 //
 // It's used by `WriteBinaryNocopy` and `WriteStringNocopy` of `BinaryProtocol`
 // which are relied by kitex tool or thriftgo
-var NocopyWriteThreshold = 4096
+const nocopyWriteThreshold = 4096
 
 // BinaryWriter represents the method used in thrift encoding for nocopy writes
 // It supports netpoll nocopy feature, see: https://github.com/cloudwego/netpoll/blob/develop/nocopy.go