feat: new unsafex pkg

.golangci.yaml

@@ -1,37 +1,10 @@
-# Options for analysis running.
-run:
-  # include `vendor` `third_party` `testdata` `examples` `Godeps` `builtin`
-  skip-dirs-use-default: true
-  skip-dirs:
-    - kitex_gen
-  skip-files:
-    - ".*\\.mock\\.go$"
-# output configuration options
-output:
-  # Format: colored-line-number|line-number|json|tab|checkstyle|code-climate|junit-xml|github-actions
-  format: colored-line-number
-# All available settings of specific linters.
-# Refer to https://golangci-lint.run/usage/linters
-linters-settings:
-  gofumpt:
-    # Choose whether to use the extra rules.
-    # Default: false
-    extra-rules: true
-  govet:
-    # Disable analyzers by name.
-    # Run `go tool vet help` to see all analyzers.
-    disable:
-      - stdmethods
-linters:
+linters: # https://golangci-lint.run/usage/linters/
+  disable-all: true
   enable:
-    - gofumpt
-    - goimports
-    - gofmt
-  disable:
     - errcheck
-    - typecheck
-    - deadcode
-    - varcheck
+    - gosimple
+    - govet
+    - ineffassign
     - staticcheck
-issues:
-  exclude-use-default: true
+    - unused
+    - unconvert

container/strmap/strmap.go

@@ -23,9 +23,9 @@ import (
 	"sort"
 	"strings"
 
-	"github.com/cloudwego/gopkg/internal/hack"
 	"github.com/cloudwego/gopkg/internal/hash/maphash"
 	"github.com/cloudwego/gopkg/internal/strstore"
+	"github.com/cloudwego/gopkg/unsafex"
 )
 
 // StrMap represents GC friendly readonly string map implementation.
@@ -133,7 +133,7 @@ func (m *StrMap[V]) Len() int {
 // It panics if i is not in the range [0, Len()).
 func (m *StrMap[V]) Item(i int) (string, V) {
 	e := &m.items[i]
-	return hack.ByteSliceToString(m.data[e.off : e.off+int(e.sz)]), e.v
+	return unsafex.BinaryToString(m.data[e.off : e.off+int(e.sz)]), e.v
 }
 
 type itemsBySlot[V any] []mapItem[V]

container/strmap/strmap_test.go

@@ -22,18 +22,18 @@ import (
 	"runtime"
 	"testing"
 
-	"github.com/cloudwego/gopkg/internal/hack"
+	"github.com/cloudwego/gopkg/unsafex"
 	"github.com/stretchr/testify/require"
 )
 
 func randStrings(m, n int) []string {
 	b := make([]byte, m*n)
-	rand.Read(b)
+	_, _ = rand.Read(b)
 	ret := make([]string, 0, n)
 	for i := 0; i < n; i++ {
 		s := b[m*i:]
 		s = s[:m]
-		ret = append(ret, hack.ByteSliceToString(s))
+		ret = append(ret, unsafex.BinaryToString(s))
 	}
 	return ret
 }
@@ -173,7 +173,7 @@ func BenchmarkLoadFromMap(b *testing.B) {
 	p := New[uint]()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		p.LoadFromMap(m)
+		_ = p.LoadFromMap(m)
 	}
 }
 
@@ -188,7 +188,7 @@ func BenchmarkLoadFromSlice(b *testing.B) {
 	p := New[int]()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		p.LoadFromSlice(kk, vv)
+		_ = p.LoadFromSlice(kk, vv)
 	}
 }
 

internal/strstore/strstore_test.go

@@ -82,7 +82,7 @@ func BenchmarkStrStoreLoad(b *testing.B) {
 	strStore := New()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		strStore.Load(ss)
+		_, _ = strStore.Load(ss)
 	}
 }
 

protocol/thrift/binary.go

@@ -23,7 +23,7 @@ import (
 	"unsafe"
 
 	"github.com/bytedance/gopkg/lang/span"
-	"github.com/cloudwego/gopkg/internal/hack"
+	"github.com/cloudwego/gopkg/unsafex"
 )
 
 var (
@@ -136,7 +136,7 @@ func (p BinaryProtocol) WriteStringNocopy(buf []byte, w NocopyWriter, v string)
 		return p.WriteString(buf, v)
 	}
 	binary.BigEndian.PutUint32(buf, uint32(len(v)))
-	_ = w.WriteDirect(hack.StringToByteSlice(v), len(buf[4:])) // always err == nil ?
+	_ = w.WriteDirect(unsafex.StringToBinary(v), len(buf[4:])) // always err == nil ?
 	return 4
 }
 
@@ -357,7 +357,7 @@ func (p BinaryProtocol) ReadString(buf []byte) (s string, l int, err error) {
 	}
 	if spanCacheEnable {
 		data := spanCache.Copy(buf[4:l])
-		s = hack.ByteSliceToString(data)
+		s = unsafex.BinaryToString(data)
 	} else {
 		s = string(buf[4:l])
 	}

protocol/thrift/binary_test.go

@@ -30,12 +30,12 @@ func TestBinary(t *testing.T) {
 
 		b := Binary.AppendBool([]byte(nil), true)
 		b = Binary.AppendBool(b, false)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteBool(b1, true)
 		l += Binary.WriteBool(b1[l:], false)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadBool(b)
@@ -53,11 +53,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.ByteLength()
 
 		b := Binary.AppendByte([]byte(nil), 1)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteByte(b1, 1)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadByte(b)
@@ -73,11 +73,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.I16Length()
 
 		b := Binary.AppendI16([]byte(nil), testv)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteI16(b1, testv)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadI16(b)
@@ -93,11 +93,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.I32Length()
 
 		b := Binary.AppendI32([]byte(nil), testv)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteI32(b1, testv)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadI32(b)
@@ -113,11 +113,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.I64Length()
 
 		b := Binary.AppendI64([]byte(nil), testv)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteI64(b1, testv)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadI64(b)
@@ -133,11 +133,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.DoubleLength()
 
 		b := Binary.AppendDouble([]byte(nil), testv)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteDouble(b1, testv)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadDouble(b)
@@ -153,11 +153,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.BinaryLength(testv)
 
 		b := Binary.AppendBinary([]byte(nil), testv)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteBinaryNocopy(b1, nil, testv)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadBinary(b)
@@ -173,11 +173,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.StringLength(testv)
 
 		b := Binary.AppendString([]byte(nil), testv)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteStringNocopy(b1, nil, testv)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		v, l, _ := Binary.ReadString(b)
@@ -193,11 +193,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.MessageBeginLength(testname)
 
 		b := Binary.AppendMessageBegin([]byte(nil), testname, testtyp, testseq)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteMessageBegin(b1, testname, testtyp, testseq)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		name, typ, seq, l, _ := Binary.ReadMessageBegin(b)
@@ -216,12 +216,12 @@ func TestBinary(t *testing.T) {
 
 		b := Binary.AppendFieldBegin([]byte(nil), testtyp, testfid)
 		b = Binary.AppendFieldStop(b)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteFieldBegin(b1, testtyp, testfid)
 		l += Binary.WriteFieldStop(b1[l:])
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		typ, fid, l, _ := Binary.ReadFieldBegin(b)
@@ -243,11 +243,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.MapBeginLength()
 
 		b := Binary.AppendMapBegin([]byte(nil), testkt, testvt, testsize)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteMapBegin(b1, testkt, testvt, testsize)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		kt, vt, size, l, _ := Binary.ReadMapBegin(b)
@@ -265,11 +265,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.ListBeginLength()
 
 		b := Binary.AppendListBegin([]byte(nil), testvt, testsize)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteListBegin(b1, testvt, testsize)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		vt, size, l, _ := Binary.ReadListBegin(b)
@@ -286,11 +286,11 @@ func TestBinary(t *testing.T) {
 		sz := Binary.SetBeginLength()
 
 		b := Binary.AppendSetBegin([]byte(nil), testvt, testsize)
-		require.Equal(t, int(sz), len(b))
+		require.Equal(t, sz, len(b))
 
 		b1 := make([]byte, sz)
 		l := Binary.WriteSetBegin(b1, testvt, testsize)
-		require.Equal(t, int(sz), l)
+		require.Equal(t, sz, l)
 		require.Equal(t, b, b1)
 
 		vt, size, l, _ := Binary.ReadSetBegin(b)

protocol/thrift/bufferreader.go

@@ -24,7 +24,7 @@ import (
 
 	"github.com/bytedance/gopkg/lang/dirtmake"
 	"github.com/cloudwego/gopkg/bufiox"
-	"github.com/cloudwego/gopkg/internal/hack"
+	"github.com/cloudwego/gopkg/unsafex"
 )
 
 // BufferReader represents a reader for binary protocol
@@ -162,7 +162,7 @@ func (r *BufferReader) ReadString() (s string, err error) {
 	if err != nil {
 		return "", err
 	}
-	return hack.ByteSliceToString(b), nil
+	return unsafex.BinaryToString(b), nil
 }
 
 // ReadMessageBegin ...
@@ -274,7 +274,7 @@ func (r *BufferReader) skipType(t TType, maxdepth int) error {
 		}
 		ksz, vsz := int(typeToSize[kt]), int(typeToSize[vt])
 		if ksz > 0 && vsz > 0 {
-			return r.skipn(int(sz) * (ksz + vsz))
+			return r.skipn(sz * (ksz + vsz))
 		}
 		for j := 0; j < sz; j++ {
 			if ksz > 0 {

protocol/thrift/bufferwriter.go

@@ -22,7 +22,7 @@ import (
 	"sync"
 
 	"github.com/cloudwego/gopkg/bufiox"
-	"github.com/cloudwego/gopkg/internal/hack"
+	"github.com/cloudwego/gopkg/unsafex"
 )
 
 type BufferWriter struct {
@@ -117,7 +117,7 @@ func (w *BufferWriter) WriteBinary(v []byte) error {
 }
 
 func (w *BufferWriter) WriteString(v string) error {
-	return w.WriteBinary(hack.StringToByteSlice(v))
+	return w.WriteBinary(unsafex.StringToBinary(v))
 }
 
 func (w *BufferWriter) WriteBool(v bool) error {