Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove tool choice in model callback input #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

N3kox
Copy link
Contributor

@N3kox N3kox commented Jan 15, 2025

What type of PR is this?

refactor: remove tool_choice in model callback input

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

⚠️ Breaking API Changes Detected

This pull request contains breaking API changes that may affect compatibility:

uncompatible api changes found: 
github.com/cloudwego/eino/components/model
  Incompatible changes:
  - CallbackInput.ToolChoice: removed

Required Actions:

  1. Please review these changes carefully
  2. Update the user documentation to reflect these API changes
  3. Add a note in the changelog about these breaking changes

Copy link

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (75%) satisfied:	PASS
Total test coverage: 82.7% (2966/3586)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant