fix: Use sip.Message instead of sip.Request for GetBranchID, close #76.

cloudwebrtc · Jan 12, 2022 · 1b0f995 · 1b0f995
1 parent 60d040f
commit 1b0f995
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/ua/ua.go b/pkg/ua/ua.go
@@ -492,7 +492,7 @@ func (ua *UserAgent) RequestWithContext(ctx context.Context, request sip.Request
 			case provisional := <-provisionals:
 				callID, ok := provisional.CallID()
 				if ok {
-					branchID := utils.GetBranchID(provisional.(sip.Request))
+					branchID := utils.GetBranchID(provisional)
 					if v, found := ua.iss.Load(NewSessionKey(*callID, branchID)); found {
 						is := v.(*session.Session)
 						is.StoreResponse(provisional)
@@ -527,7 +527,7 @@ func (ua *UserAgent) RequestWithContext(ctx context.Context, request sip.Request
 			case response := <-responses:
 				callID, ok := response.CallID()
 				if ok {
-					branchID := utils.GetBranchID(response.(sip.Request))
+					branchID := utils.GetBranchID(response)
 					if v, found := ua.iss.Load(NewSessionKey(*callID, branchID)); found {
 						if request.IsInvite() {
 							is := v.(*session.Session)

diff --git a/pkg/utils/util.go b/pkg/utils/util.go
@@ -16,8 +16,8 @@ var (
 	ErrPort       = errors.New("invalid port")
 )
 
-func GetBranchID(request sip.Request) sip.MaybeString {
-	if viaHop, ok := request.ViaHop(); ok {
+func GetBranchID(msg sip.Message) sip.MaybeString {
+	if viaHop, ok := msg.ViaHop(); ok {
 		if branch, ok := viaHop.Params.Get("branch"); ok {
 			return branch
 		}