Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify testing for Cloud Posse components #41
base: main
Are you sure you want to change the base?
Simplify testing for Cloud Posse components #41
Changes from all commits
85cebe6
ea0672c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Avoid failing the test during cleanup when destroy operation fails
If the destroy operation fails during cleanup, using
assert.NoError
will fail the test at the end. Consider logging the error to report the issue without failing the entire test.Apply this diff to log the error instead:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure
copyDirectoryRecursively
function is defined or importedThe function
copyDirectoryRecursively
used on line 70 is not defined in this file or imported from any package. This will result in a build error.Please define the
copyDirectoryRecursively
function or import it from the appropriate package to ensure the code compiles correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve error handling for clone failure
Returning an empty
shell.Command{}
when cloning fails could lead to silent failures downstream. Consider either:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove commented code and track the issue properly
The commented code block indicates that the
--base-path
flag doesn't work in Atmos 1.109.0, but leaves the code in place without proper tracking. Instead of keeping commented code:📝 Committable suggestion