Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional users feature #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

idjemaoune
Copy link

what
Add support for setting up additional MQ users
why
Additional users were needed for the project
Full backward compatibility. Nothing will change if variables mq_additional_users or mq_configuration are undefined.

@idjemaoune idjemaoune requested review from a team as code owners October 17, 2023 09:26
@idjemaoune
Copy link
Author

@dotCipher @jamengual Please consider adding this development, as we really need this feature.

@jamengual
Copy link

@idjemaoune could you please run make precommit/terraform and commit the changes? thanks.

@hans-d
Copy link
Contributor

hans-d commented Mar 2, 2024

/terratest

@hans-d
Copy link
Contributor

hans-d commented Mar 3, 2024

@idjemaoune Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
Copy link

mergify bot commented Mar 9, 2024

Thanks @idjemaoune for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants