Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mq configurations #67

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add mq configurations #67

wants to merge 7 commits into from

Conversation

danushkaf
Copy link

@danushkaf danushkaf commented Sep 20, 2023 •
edited by goruha
Loading

what

This change is to allow users to configure MQ configurations with this module

why

With current version there is no way to attach configurations to brokers

references

#66

@danushkaf danushkaf requested review from a team as code owners September 20, 2023 14:06
@hans-d
Copy link
Contributor

hans-d commented Mar 2, 2024

/terratest

@hans-d
Copy link
Contributor

hans-d commented Mar 4, 2024

/terratest

@hans-d
Copy link
Contributor

hans-d commented Mar 4, 2024

/terratest

@hans-d hans-d self-assigned this Mar 4, 2024
@hans-d hans-d added the stale This PR has gone stale label Mar 4, 2024
@hans-d
Copy link
Contributor

hans-d commented Mar 5, 2024

@danushkaf can you update this pr?

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme

That way we can continue to process it, otherwise it's likely to be closed.

@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Thanks @danushkaf for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Mar 16, 2024
@matthewmrichter
Copy link

Hi @hans-d, could we potentially revisit this PR? I don't know much about the failing tests, but it seems rather straightforward to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

@hans-d hans-d

Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danushkaf @hans-d @matthewmrichter @dbastion @goruha