Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creation of CloudWatch logging, additional policy attachment, and KMS decryption #111

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Allow creation of CloudWatch logging, additional policy attachment, and KMS decryption #111

wants to merge 30 commits into from

Conversation

LawrenceWarren
Copy link

what

  • Allow optional creation of a CloudWatch logs natively within the module, as logging for Bastion nodes is a common requirement
  • Expand the user_data/amazon-linux.sh script to enable debug logging.
  • Allow optional attachment of additional IAM policies, via a list of provided policy ARNs, so that the bation can optionally have more access
  • Allow optional KMS decryption on the bastion

why

  • Simply, these all seem like sensible options to provide users, and are common use-cases that my company use on our internal fork.
  • These changes are not breaking.

cc-robertson and others added 29 commits March 22, 2021 19:26
@cc-robertson
updated module to also instance ec2 instance connect
da5777a
@cc-robertson
updated vars, provider inputs & configuration for host_name records i…
b8afd84 
…n route 53
@cc-robertson
feat: added cloudwatch log group to bastion module
507924c
@cc-robertson
resolved merge conflict
3a470b1
@cc-robertson
Merge branch 'cloudposse-master'
e284f6f
@cc-robertson
feat: removed unneccessary varaibles that get loaded by terragrunt fr…
7de4989 
…amework
@cc-robertson
Merge branch 'master' into HT-4046
d14aabc
@cc-robertson
fix: resolved outputs from cloudwatch
9b5bff1
@cc-robertson
fix: resolved outputs from cloudwatch
716f73e
@cc-robertson
fix: resolved outputs from cloudwatch
43f9cc2
@cc-robertson
feat: removed isntance connect
6124809
@cc-robertson
fix: removed conenct logic from user_data
71f4605
@Callumccr
Merge pull request #1 from humn-ai/HT-4046
58f9537 
Ht 4046 | added cloudwatch log group
@cc-robertson
feat: updated user_data, updated IAM policy for instance profile
018638d
@cc-robertson
added kms:generatedatakey"
3f83262 
"
@cc-robertson
added additional iam policy
bd41d31
@cc-robertson
added kms:generatedatakey"
505dd40 
"
@cc-robertson
fixed existing policies
abe649d
@cc-robertson
fixed existing policies
2c4f560
@cc-robertson
fixed existing policies
8a16910
@cc-robertson
fixed existing policies
bb7a7f2
@cc-robertson
feat: added tags to ebs volume
b262af7
Merge 'cloudposse/master' -v0.30.1
236ad73
@yadachi
Merge pull request #5 from humn-ai/HT-7895-update-latest
0c51188 
HT-7895 pull the latest update
fix: add versions.tf and remove terraform.tf
c372b2c
fix: pass kms_key_arn in the policy
34b643d
@yadachi
Merge pull request #6 from humn-ai/HT-7895-fix-policy
8904c3e 
HT-7895 Fix KMS policy
@LawrenceWarren
feat(tf): Update config to be suitable for a CloudPosse PR
9fbae47
@LawrenceWarren
fix(tf): Restore amazon-linux.sh script
ee13915
@LawrenceWarren LawrenceWarren requested a review from a team as a code owner September 6, 2023 11:28
@LawrenceWarren
Copy link
Author

/terratest

1 similar comment
@hans-d
Copy link

hans-d commented Mar 8, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Thanks @LawrenceWarren for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LawrenceWarren @hans-d @cc-robertson @Callumccr @yadachi