Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update deprecated resource value for resource_collection_enabled #66

Closed
wants to merge 3 commits into from
Closed

fix: update deprecated resource value for resource_collection_enabled #66

wants to merge 3 commits into from

Conversation

RoseSecurity
Copy link

@RoseSecurity RoseSecurity commented Oct 18, 2024 •
edited
Loading

what

  • Documentation includes terraform-docs fix for how <br/> is interpreted
  • Fixes this warning:
│ Warning: Argument is deprecated
│ 
│   with module.datadog_integration.datadog_integration_aws.integration[0],
│   on .terraform/infra/modules/datadog_integration/main.tf line 28, in resource "datadog_integration_aws" "integration":
│   28:   resource_collection_enabled      = var.resource_collection_enabled
│ 
│ Deprecated in favor of `extended_resource_collection_enabled`.
  • Adds the parameter to examples for testing

why

references

@RoseSecurity
fix: update deprecated resource collection to extended_resource_colle…
e06c0be 
…ction_enabled and add to examples for testing
@RoseSecurity RoseSecurity requested review from a team as code owners October 18, 2024 14:05
@mergify mergify bot added the triage Needs triage label Oct 18, 2024
@RoseSecurity
Copy link
Author

/terratest

@RoseSecurity
Copy link
Author

/terratest

@RoseSecurity RoseSecurity requested a review from Nuru October 23, 2024 21:12
Nuru
Nuru requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update versions.tf to require the first version of the Datadog provider that supports extended_resource_collection_enabled, which I think is 3.39.0

main.tf
Comment on lines +28 to +29
resource_collection_enabled = var.resource_collection_enabled
extended_resource_collection_enabled = var.extended_resource_collection_enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserve backward compatibility while removing deprecated resource:

Suggested change
resource_collection_enabled = var.resource_collection_enabled
extended_resource_collection_enabled = var.extended_resource_collection_enabled
extended_resource_collection_enabled = var.resource_collection_enabled != null ? var.resource_collection_enabled : var.extended_resource_collection_enabled

@RoseSecurity RoseSecurity closed this by deleting the head repository Nov 13, 2024
@mergify mergify bot removed the triage Needs triage label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru requested changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoseSecurity @Nuru