Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with the component_info output from the atmos describe component command. Add assume_role property to Atmos JSON Schema S3 backend #621

Merged
merged 12 commits into from
Jun 8, 2024

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jun 8, 2024

what

  • Fix an issue with the component_info output from the atmos describe component command
  • Add assume_role property to Atmos JSON Schema S3 backend

why

  • The issue with the component_info output from the atmos describe component command was introduced in the previous PRs (different order of execution when evaluation Go templates in Atmos stack manifests)

  • Support the recommended assume_role property in S3 backends. Assuming an IAM Role can be configured in two ways. The preferred way is to use the argument assume_role, the other, which is deprecated, is with arguments at the top level (e.g. role_arn)

references

@aknysh aknysh added the minor New features that do not break anything label Jun 8, 2024
@aknysh aknysh requested review from osterman and goruha June 8, 2024 15:28
@aknysh aknysh self-assigned this Jun 8, 2024
@aknysh aknysh requested review from a team as code owners June 8, 2024 15:28
@aknysh aknysh requested review from Gowiem and gberenice June 8, 2024 15:28
@aknysh aknysh merged commit f466925 into main Jun 8, 2024
14 checks passed
@aknysh aknysh deleted the atmos-template-functions-1 branch June 8, 2024 19:47
Copy link

github-actions bot commented Jun 8, 2024

These changes were released in v1.79.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants