Migrate to ECS environment #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ShotaKitazawa
commented
Apr 14, 2024
•
ShotaKitazawa
commented
- EKS -> ECS 移行に伴い、 GitHub Actions からの push 先 ECR repository を変更
- push branches: dev, stage (us-west-2) で利用
- push tags: prod (ap-northeast-1) で利用
- ReviewApps 用 Action の更新
ShotaKitazawa
force-pushed
the
migrate-to-ecs
branch
from
048d54f
to
6f8ba30
Compare
ShotaKitazawa
force-pushed
the
migrate-to-ecs
branch
from
6f8ba30
to
5a38b3b
Compare
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 3, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 3, 2024
commit: cloudnativedaysjp/dreamkast-weaver@87bcd4c Co-authored-by: GitHub Action <[email protected]>
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 3, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 3, 2024
commit: cloudnativedaysjp/dreamkast-weaver@87bcd4c Co-authored-by: GitHub Action <[email protected]>
ShotaKitazawa
force-pushed
the
migrate-to-ecs
branch
from
87bcd4c
to
c0a9aaf
Compare
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 3, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 3, 2024
commit: cloudnativedaysjp/dreamkast-weaver@c0a9aaf Co-authored-by: GitHub Action <[email protected]>
|
（細かいところまで動作把握できてませんが）ぱっとみLGTMですー 本質とは関係ないですが、jsonnetってコマンドがあるんですね 👀 |
ystkfujii
approved these changes
May 3, 2024
hrk091
reviewed
May 5, 2024
There was a problem hiding this comment.
cloudnativedaysjp/dreamkast-ui#491 と変更内容ほぼ同じだと思うので、あちらのコメントで対応したものがあれば、こちらにも横展開いただけると助かります！！
…ons/github-script
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 5, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 5, 2024
commit: cloudnativedaysjp/dreamkast-weaver@cd5a434 Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.