Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force rehearsal mode even when the pre-conference or conference day #514

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

hrk091
Copy link
Member

@hrk091 hrk091 commented Jun 15, 2024

プレイベをdkでやらなかった場合に、カンファレンス前日にプレイベの予定が入っていることが多いですが、このケースにおいてdkから取得できた日付を優先すると、前日リハでプレイベ側のデータを取りに行ってしまい困ります。

リハーサルモードの場合は、プレイベの日だろうがカンファレンス当日のデータを取りに行くようにしました。

@hrk091 hrk091 requested review from jacopen and takaishi June 15, 2024 00:22
@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Jun 15, 2024
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 15, 2024
Copy link

gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 15, 2024
@takaishi takaishi merged commit 23cb2e7 into main Jun 19, 2024
5 checks passed
@takaishi takaishi deleted the fix/force_rehearsal_mode branch June 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewapps Build ReviewApp environment automatically if this label is granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants