-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline Support for thingler #9
Open
saimonmoore
wants to merge
32
commits into
cloudhead:master
Choose a base branch
from
saimonmoore:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays regenerate in dev mode)
… Removing default '/' value for network session. Adding eof newline.
…ffline fallback page for accesses to new urls
…ding appcache event logging for debugging.
…er just update it)
…ll browsers support these)
…an error if browser fallsback to offline page
…generating. Add key as etag header and set expires/last-modified
… headers to manifest request. Add cache-control no-cache header to routed requests. Remove debug statement from routed requests.
…d accept header reset issue in firefox.
…ents. default off
Alexis have you had a chance to review this code? |
Hi Alexis, Though you're probably not much interested in thingler any more I'd appreciate feedback on this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: