Skip ssl validation if the option is already provided #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanBorislavovDimitrov
force-pushed
the
skip-ssl-validation
branch
from
8a70469
to
4f2f36f
Compare
|
Another client is only used when fetching the size of the MTA during upload from URL, but I do not think we should deactivate the TLS since it is not related to CF |
IvanBorislavovDimitrov
force-pushed
the
skip-ssl-validation
branch
2 times, most recently
from
2e6fd42
to
b517261
Compare
theghost5800
approved these changes
Dec 15, 2023
IvanBorislavovDimitrov
force-pushed
the
skip-ssl-validation
branch
from
b517261
to
7d8c206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-ssl-validation -> Skips verification of the API endpoint.
But even though it is set, the option is ignored by the plugin and it continues to require SSL validation.
This PR fixes this behavior and ignores the validation if --skip-ssl-validation is provided during login or API selection.