h3i: extract connection creation to its own function #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
reviewed
Nov 18, 2024
LPardue
reviewed
Nov 18, 2024
LPardue
reviewed
Nov 18, 2024
LPardue
reviewed
Nov 18, 2024
LPardue
requested changes
Nov 18, 2024
evanrittenhouse
force-pushed
the
evanrittenhouse/h3i-config
branch
3 times, most recently
from
0d70432
to
3f22174
Compare
evanrittenhouse
force-pushed
the
evanrittenhouse/h3i-config
branch
from
3f22174
to
8d9d55f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the diff is just copy-pasting the function from one place to another. This will deduplicate a bunch of code between the sync and async versions