New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure peer verification when using apps/client #1854

Open

nnathan wants to merge 1 commit into cloudflare:master from nnathan:fix_client_verify

+1 −0

nnathan commented Sep 27, 2024

The apps/client example doesn't verify peer when the --trust-origin-ca-pem is specified.

Before:

$ target/debug/quiche-server --name localhost --listen [::1]:4443 --cert certificate.crt --key private.key --index index.html --root $PWD

[...]

$ target/debug/quiche-client https://localhost:4443/ --trust-origin-ca-pem t/certificate.crt # t/certificate.crt is wrong cert
foobar

After:

$ target/debug/quiche-client https://localhost:4443/ --trust-origin-ca-pem t/certificate.crt
[2024-09-27T22:09:17.019056000Z ERROR quiche_apps::client] [::]:62349: recv failed: TlsFail
[2024-09-27T22:09:17.038019000Z ERROR quiche_apps::client] connection timed out after 22.2585ms

$ target/debug/quiche-client https://localhost:4443/ --trust-origin-ca-pem certificate.crt # correct cert
foobar


          apps: ensure client verifies peer by default

2d783b4

nnathan requested a review from a team as a code owner

September 27, 2024 22:10

nnathan mentioned this pull request

apps: Implement mutual tls with optional strict trust #1855

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet