Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cargo-machete in the workflow #1815

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

junhochoi
Copy link
Contributor

@junhochoi junhochoi commented Jul 12, 2024

Run cargo-machete for unused dependency check, only on
a default ssl target. Also removed unused dependencies
recommended by an initial run of cargo-machete.

@junhochoi junhochoi requested a review from a team as a code owner July 12, 2024 02:42
Run cargo-machete for unused dependency check, only on
a default ssl target.
Recommended by cargo-machete
Copy link
Contributor

@rushilmehra rushilmehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Why only run on matrix.tls-feature == ''

@junhochoi
Copy link
Contributor Author

junhochoi commented Jul 12, 2024

Nice! Why only run on matrix.tls-feature == ''

Because it seems redundant on other tls features. Also installing cargo-machete takes some time.
Instead we can try cargo-quickinstall to save an installation time, but it will produce the same result
regardless of tls-feature anyway.

@rushilmehra rushilmehra self-requested a review July 12, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants