fix: webpack chunks not deduping with sentry #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90a94ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/11134506626/npm-package-next-on-pages-886@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/11134506626/npm-package-eslint-plugin-next-on-pages-886 |
james-elicx
force-pushed
the
james/fix-sentry-dedup
branch
from
9170650
to
eaa2ef0
Compare
1 task
james-elicx
force-pushed
the
james/fix-sentry-dedup
branch
from
eaa2ef0
to
8181cdd
Compare
james-elicx
changed the title
james-elicx
force-pushed
the
james/fix-sentry-dedup
branch
from
8181cdd
to
0a01c75
Compare
dario-piotrowicz
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
The change looks good to me, thanks a lot @james-elicx 🫶
Ideally I think the code should be more robust and deal with all the SequenceExpression's expressions, but that doesn't need to be a blocker for this PR
Open
1 task
Merged
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sentry, you get a SequenceExpression with the CallExpression inside it. We need to find that CallExpression so we can use it for deduping.
fixes #860