implement route scoping solution #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca1ab06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10214693462/npm-package-next-on-pages-836@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10214693462/npm-package-eslint-plugin-next-on-pages-836 |
dario-piotrowicz
changed the title
dario-piotrowicz
force-pushed
the
useContext-fix
branch
from
88c1452
to
e11f952
Compare
dario-piotrowicz
force-pushed
the
useContext-fix
branch
2 times, most recently
from
b122cc1
to
60158e1
Compare
dario-piotrowicz
force-pushed
the
useContext-fix
branch
from
56d65f2
to
03154df
Compare
vicb
reviewed
Jul 31, 2024
vicb
reviewed
Jul 31, 2024
vicb
reviewed
Jul 31, 2024
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Jul 31, 2024
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Jul 31, 2024
There was a problem hiding this comment.
I have done a first pass of review with my very limited knowedlge.
I'll do a second pass of review tomorrow.
One thing that would be nice is a high level description of what the PR do - 1 or 2 sentences to give context, describes the problem that is solved (the content is currently empty).
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
james-elicx
reviewed
Jul 31, 2024
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
dario-piotrowicz
force-pushed
the
useContext-fix
branch
from
03154df
to
ef3df46
Compare
update regex
use a single return statement instead of updating fileContents
add missing semicolon
avoid unnecessary spreading
dario-piotrowicz
force-pushed
the
useContext-fix
branch
from
7842b1c
to
c1f5650
Compare
generalize regex
improve buildFunctionFile code and make it more clear
add entries()
vicb
reviewed
Aug 1, 2024
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
avoid string concatenation for functionImports
fix incorrect entries call
avoid introducing named esm exports for then regex-replace them
introduce namedExportsObjectName to make solution less ugly/brittle
fix wrong namedExportsObjectName name
update namedExportsObjectName name (for consistency)
improve named exports solution a bit further
make sure solution works with older versions of the Vercel CLI
dario-piotrowicz
force-pushed
the
useContext-fix
branch
from
8824942
to
b37bce2
Compare
dario-piotrowicz
commented
Aug 2, 2024
vicb
reviewed
Aug 2, 2024
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Aug 2, 2024
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
vicb
approved these changes
Aug 2, 2024
use more consistent param names
join using newlines instead of semicolons
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently routes all share the same global scope, this can be problematic and cause race conditions and failures, like the one presented in #805 that happens when various requests are handled in parallel (and the global scope ends up in an invalid state).
So, this PR solves the issue by wrapping each js file (functions and chunks included) in functions that override the
self,globalThisandglobalsymbols with proxies that try to make (as reasonably well as possible) each route's global scope as isolated as possible.fixes #805