refactor solution further

packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts

@@ -221,7 +221,7 @@ async function buildFunctionFile(
 	}, new Map<string, string>());
 
 	let chunkMapIdx = 0;
-	const chunksMap = new Map<string, Set<string>>();
+	const chunksExportsMap = new Map<string, Set<string>>();
 
 	groupedImports.forEach((keys, path) => {
 		const relativeImportPath = getRelativePathToAncestor({
@@ -233,7 +233,7 @@ async function buildFunctionFile(
 		);
 
 		const namedExportsId = `getNamedExports_${chunkMapIdx++}`;
-		chunksMap.set(namedExportsId, new Set([...keys.split(',')]));
+		chunksExportsMap.set(namedExportsId, new Set([...keys.split(',')]));
 		functionImports += `import { getNamedExports as ${namedExportsId} } from '${importPath}';\n`;
 	});
 
@@ -243,7 +243,7 @@ async function buildFunctionFile(
 		fileContents,
 		functionImports,
 		fnInfo,
-		chunksMap,
+		chunksExportsMap,
 	);
 	const buildPromise = buildFile(finalFileContents, newFnPath, {
 		relativeTo: nopDistDir,
@@ -269,14 +269,14 @@ type BuildFunctionFileOpts = {
  * @param fileContents the function file's contents
  * @param functionImports the imports that need to be added to the file
  * @param fnInfo the function's information
- * @param chunksMap a map containing getters and chunks being used by the function
+ * @param chunksExportsMap a map containing getters and chunks identifiers being used by the function
  * @returns the updated/iifefied file content
  */
 function iffefyFunctionFile(
 	fileContents: string,
 	functionImports: string,
 	fnInfo: FunctionInfo,
-	chunksMap: Map<string, Set<string>>,
+	chunksExportsMap: Map<string, Set<string>>,
 ): string {
 	const wrappedContent = `
 		export default ((self, globalThis, global) => {
@@ -294,12 +294,16 @@ function iffefyFunctionFile(
 		`const proxy = globalThis.__nextOnPagesRoutesIsolation.getProxyFor('${
 			fnInfo.route?.path ?? ''
 		}');`,
-		[...chunksMap].map(([getNamedExportsId, keys]) => {
-			return `const exportsOf${getNamedExportsId} = ${getNamedExportsId}(proxy, proxy, proxy);
-				${[...keys]
-					.map(key => `const ${key} = exportsOf${getNamedExportsId}["${key}"]`)
-					.join(';')}`;
-		}),
+		[
+			...[...chunksExportsMap].map(([getNamedExportsId, keys]) => {
+				return [
+					`const exportsOf${getNamedExportsId} = ${getNamedExportsId}(proxy, proxy, proxy)`,
+					[...keys].map(
+						key => `const ${key} = exportsOf${getNamedExportsId}["${key}"]`,
+					),
+				];
+			}),
+		],
 		wrappedContent,
 	].join(';');
 }