Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Added support for Cloudflare Workflows #3668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nadenf
Copy link

@nadenf nadenf commented Nov 23, 2024

Description

Adds support for the newly released Cloudflare Workflows product.

Has your change been tested?

No.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Nov 23, 2024

changelog detected ✅

@nadenf nadenf changed the title [DO NOT MERGE] Added support for Cloudflare Workflows [DRAFT] Added support for Cloudflare Workflows Nov 23, 2024
@nadenf
Copy link
Author

nadenf commented Nov 23, 2024

@jacobbednarz .. Can I request approval to have this PR be tested by GHA.

@jacobbednarz
Copy link
Member

workflows already exists in v3 (codegen'd library). do you want to use that for terraform support instead?

@nadenf
Copy link
Author

nadenf commented Nov 23, 2024

workflows already exists in v3 (codegen'd library). do you want to use that for terraform support instead?

Confused. Do you mean using the existing code from the v3 library in this one.

Or having terraform-provider-cloudflare use the v3 library ?

@jacobbednarz
Copy link
Member

the latter as workflows endpoints already exists on next since the endpoints are documented.

if you hit me up in chat, we can also talk about the next steps as we can probably just enable this on the terraform side too and you don't need to manually maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants