swap booleans to pointers

https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans
cloudflare · Nov 20, 2024 · d11c2e9 · d11c2e9
1 parent ea51d51
commit d11c2e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/leaked_credential_check.go b/leaked_credential_check.go
@@ -11,7 +11,7 @@ import (
 type LeakedCredentialCheckGetStatusParams struct{}
 
 type LeakedCredentialCheckStatus struct {
-	Enabled bool `json:"enabled"`
+	Enabled *bool `json:"enabled"`
 }
 
 type LeakCredentialCheckStatusResponse struct {
@@ -20,7 +20,7 @@ type LeakCredentialCheckStatusResponse struct {
 }
 
 type LeakCredentialCheckSetStatusParams struct {
-	Enabled bool `json:"enabled"`
+	Enabled *bool `json:"enabled"`
 }
 
 type LeakedCredentialCheckListDetectionsParams struct{}

diff --git a/leaked_credential_check_test.go b/leaked_credential_check_test.go
@@ -27,7 +27,7 @@ func TestLeakedCredentialCheckGetStatus(t *testing.T) {
 	mux.HandleFunc("/zones/"+testZoneID+"/leaked-credential-checks", handler)
 
 	want := LeakedCredentialCheckStatus{
-		Enabled: true,
+		Enabled: BoolPtr(true),
 	}
 	actual, err := client.LeakedCredentialCheckGetStatus(context.Background(), ZoneIdentifier(testZoneID), LeakedCredentialCheckGetStatusParams{})
 	if assert.NoError(t, err) {
@@ -53,7 +53,7 @@ func TestLeakedCredentialCheckSetStatus(t *testing.T) {
 	mux.HandleFunc("/zones/"+testZoneID+"/leaked-credential-checks", handler)
 
 	want := LeakedCredentialCheckStatus{
-		Enabled: false,
+		Enabled: BoolPtr(false),
 	}
 	actual, err := client.LeakedCredentialCheckSetStatus(context.Background(), ZoneIdentifier(testZoneID), LeakCredentialCheckSetStatusParams{false})
 	if assert.NoError(t, err) {