Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPCP-10789 Environment Proxy Configuration Create/Read/Delete #67

Merged
merged 2 commits into from
Dec 6, 2023
Merged

CDPCP-10789 Environment Proxy Configuration Create/Read/Delete #67

merged 2 commits into from
Dec 6, 2023

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Nov 22, 2023

No description provided.

@daszabo daszabo requested a review from a team as a code owner November 22, 2023 08:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Go test coverage: 21.0% for commit aea1367
⚠️ 2 of 9 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest             |    28.0%
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    27.0%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    22.9%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    42.2%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

@gregito gregito force-pushed the CDPCP-10789 branch 2 times, most recently from 09902fa to db3fb29 Compare December 5, 2023 14:25
@gregito gregito self-requested a review December 5, 2023 14:32
gregito
gregito approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the pr accordingly to my requests

@gregito gregito enabled auto-merge (rebase) December 5, 2023 15:01
@gregito gregito requested a review from a team December 5, 2023 15:07
@daszabo daszabo requested a review from gregito December 5, 2023 15:15
gregito
gregito previously approved these changes Dec 5, 2023
View reviewed changes
enis
enis reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@enis enis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. A more of less straightforward resource that follows the existing established patterns. Just minor comments.

resources/environments/model_proxy_configuration.go Show resolved Hide resolved
resources/environments/model_proxy_configuration.go Outdated Show resolved Hide resolved
resources/environments/resource_proxy_configuration.go Show resolved Hide resolved
resources/environments/schema_proxy_configuration.go Outdated Show resolved Hide resolved
resources/environments/resource_proxy_configuration.go Show resolved Hide resolved
@gregito gregito self-requested a review December 6, 2023 16:49
@gregito gregito merged commit efb023a into main Dec 6, 2023
6 checks passed
enis
enis reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@enis enis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactive +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enis enis enis left review comments

@gregito gregito gregito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daszabo @enis @gregito