Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPCP-10154 - increase unit test coverage for the datahub package #63

Merged
merged 1 commit into from
Nov 16, 2023
Merged

CDPCP-10154 - increase unit test coverage for the datahub package #63

merged 1 commit into from
Nov 16, 2023

Conversation

gregito
Copy link
Contributor

@gregito gregito commented Nov 3, 2023

No description provided.

@gregito gregito marked this pull request as ready for review November 3, 2023 07:41
@gregito gregito requested a review from a team as a code owner November 3, 2023 07:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

Go test coverage: 17.4% for commit ff5d340
⚠️ 2 of 8 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    27.0%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    15.8%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    33.9%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

enis
enis approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@enis enis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gregito gregito merged commit 882a341 into main Nov 16, 2023
6 checks passed
@gregito gregito deleted the CDPCP-10154 branch November 16, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enis enis enis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregito @enis