Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPCP-9522 - unit tests for Terraform Provider for CDP #50

Merged
merged 1 commit into from
Nov 15, 2023
Merged

CDPCP-9522 - unit tests for Terraform Provider for CDP #50

merged 1 commit into from
Nov 15, 2023

Conversation

gregito
Copy link
Contributor

@gregito gregito commented Aug 7, 2023

No description provided.

@gregito gregito requested a review from a team as a code owner August 7, 2023 13:06
@gregito gregito force-pushed the CDPCP-9522 branch 4 times, most recently from 247f8e4 to 29e85a7 Compare August 7, 2023 13:22
gregito
gregito commented Aug 7, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

Go test coverage: 16.1% for commit c370720
⚠️ 2 of 8 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    20.2%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    15.8%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    33.9%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

enis
enis reviewed Aug 9, 2023
View reviewed changes
provider/provider_test.go Show resolved Hide resolved
provider/provider_test.go Show resolved Hide resolved
provider/provider_test.go Show resolved Hide resolved
provider/provider_test.go Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
@gregito gregito force-pushed the CDPCP-9522 branch 3 times, most recently from cb3f19b to f2cdd47 Compare August 14, 2023 09:23
daszabo
daszabo previously approved these changes Aug 14, 2023
View reviewed changes
@gregito gregito force-pushed the CDPCP-9522 branch 14 times, most recently from 88742cc to 4446fdc Compare August 16, 2023 14:24
enis
enis reviewed Aug 18, 2023
View reviewed changes
utils/test/compare.go Show resolved Hide resolved
utils/test/compare.go Outdated Show resolved Hide resolved
@gregito gregito force-pushed the CDPCP-9522 branch 3 times, most recently from 653cc90 to 8c084d9 Compare October 29, 2023 08:58
@gregito
Copy link
Contributor Author

gregito commented Oct 30, 2023

@enis could you please take a look into it?

enis
enis reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@enis enis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on it. Did one more pass, we are pretty close.

utils/test/compare.go Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
provider/provider_test.go Outdated Show resolved Hide resolved
enis
enis previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@enis enis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@gregito gregito enabled auto-merge (rebase) November 15, 2023 08:54
@gregito gregito merged commit 8ae84f0 into main Nov 15, 2023
6 checks passed
@gregito gregito deleted the CDPCP-9522 branch November 15, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daszabo daszabo daszabo approved these changes

@enis enis enis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregito @enis @daszabo