-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DWX-19297 Extend hive virtual warehouse with all available properties #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevesz
commented
Dec 10, 2024
tevesz
commented
Dec 10, 2024
tevesz
commented
Dec 10, 2024
Go test coverage: 33.4% for commit b994c6b
|
Add all available configuration parameters to the hive VW.
The jdbc url and other endpoint parameters are calculated during virtual warehouse creation. These are output parameters of a virtual warehouse.
The AWS tags should annotate the compute nodes for the customer. The creation parameters are passed in this change.
Image version and acceptance tests.
Move the properties high level, rename some of them to a more meaningful name.
tevesz
force-pushed
the
DWX-19297
branch
2 times, most recently
from
December 16, 2024 22:20
ab35b38
to
2b2ef65
Compare
conflicting Either headroom or scale wait time should be set
tevesz
commented
Dec 16, 2024
prateek1192
reviewed
Dec 17, 2024
prateek1192
reviewed
Dec 17, 2024
vcsomor
previously approved these changes
Dec 17, 2024
prateek1192
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change exposes all properties required for creating a Hive virtual warehouse in a data warehouse CDP cluster. In addition to creation, it introduces the capability to delete the virtual warehouse. However, update and import functionalities are not included in this change. The virtual warehouse is dependent on the data warehouse cluster and a data lake object. Conflicting properties have been validated using the validation framework.
Testing
The changes have been tested using new unit and acceptance tests:
Documentation and examples
Examples and documentation have been generated for this change.