Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWX-19297 Extend hive virtual warehouse with all available properties #186

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Dec 10, 2024

Summary

This change exposes all properties required for creating a Hive virtual warehouse in a data warehouse CDP cluster. In addition to creation, it introduces the capability to delete the virtual warehouse. However, update and import functionalities are not included in this change. The virtual warehouse is dependent on the data warehouse cluster and a data lake object. Conflicting properties have been validated using the validation framework.

Testing

The changes have been tested using new unit and acceptance tests:

  • The acceptance tests create a CDP environment, a data lake, and an AWS-based Kubernetes cluster for the data warehouse. The Hive virtual warehouse is deployed on this Kubernetes cluster.
  • Both failure and success scenarios have been verified with the new unit tests.

Documentation and examples

Examples and documentation have been generated for this change.

utils/utils.go Show resolved Hide resolved
Copy link

github-actions bot commented Dec 10, 2024

Go test coverage: 33.4% for commit b994c6b
⚠️ 2 of 14 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                                  | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                         |    14.3%
+ github.com/cloudera/terraform-provider-cdp/provider                           |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                  |    35.8%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                 |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws           |    71.9%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog       |    65.8%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive |    77.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments             |    42.6%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                      |     2.7%
- github.com/cloudera/terraform-provider-cdp/resources/ml                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                     |    25.4%
+ github.com/cloudera/terraform-provider-cdp/utils                              |    57.1%
+ github.com/cloudera/terraform-provider-cdp/utils/test                         |    75.0%

Add all available configuration parameters to the hive VW.
The jdbc url and other endpoint parameters are calculated during virtual
warehouse creation. These are output parameters of a virtual warehouse.
The AWS tags should annotate the compute nodes for the customer. The
creation parameters are passed in this change.
Image version and acceptance tests.
Move the properties high level, rename some of them to a more meaningful
name.
@tevesz tevesz force-pushed the DWX-19297 branch 2 times, most recently from ab35b38 to 2b2ef65 Compare December 16, 2024 22:20
conflicting

Either headroom or scale wait time should be set
@tevesz tevesz marked this pull request as ready for review December 16, 2024 23:15
@tevesz tevesz requested a review from a team as a code owner December 16, 2024 23:15
@vcsomor vcsomor self-requested a review December 17, 2024 07:57
vcsomor
vcsomor previously approved these changes Dec 17, 2024
docs/resources/dw_vw_hive.md Outdated Show resolved Hide resolved
resources/dw/virtualwarehouse/hive/model_hive_vw.go Outdated Show resolved Hide resolved
resources/dw/virtualwarehouse/hive/model_hive_vw.go Outdated Show resolved Hide resolved
@tevesz tevesz enabled auto-merge (squash) December 18, 2024 01:57
@tevesz tevesz merged commit 2040668 into main Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants