Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kudu support #200

Closed

Conversation

kennycontreras
Copy link

Describe your changes

Added Kudu support providing the option to set primary key when materializing tables (option required by Kudu).

Before this, dbt-impala could only materialize views, but when it came time to create tables, it failed because of the primary key requirements.

Internal Jira ticket number or external issue link

Testing procedure/screenshots(if appropriate):

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@kennycontreras kennycontreras marked this pull request as ready for review June 4, 2024 03:36
@niteshy
Copy link
Collaborator

niteshy commented Jun 4, 2024

Thanks @kennycontreras for adding the kudu support. Can you please add the appropriate tests too?

@kennycontreras
Copy link
Author

Thanks @kennycontreras for adding the kudu support. Can you please add the appropriate tests too?

I'll add the test as soon as possible! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants