Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-781: Improve the performance of functional tests. #198

Merged
merged 3 commits into from
May 3, 2024

Conversation

vamshikolanu
Copy link
Collaborator

@vamshikolanu vamshikolanu commented May 2, 2024

Describe your changes

As part of this PR, Made changes to improve the performance of functional tests. The previous runtime for all the tests was around 90 mins. Now all the tests complete under 12 mins. Was able to achieve this by running tests in parallel using pytest-xdist library.

Also using this test suite, we can test the adapter for multiple versions of python using tox.

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-781

Testing procedure/screenshots(if appropriate):

https://gist.github.com/vamshikolanu/97f6f9d637e825fcdd0efa73a87f1c77
Individual test: https://gist.github.com/vamshikolanu/b1b12a06950e5d0b874ca2550e259760

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

Makefile Outdated Show resolved Hide resolved
@vamshikolanu vamshikolanu merged commit 2a8d8ae into master May 3, 2024
vamshikolanu added a commit that referenced this pull request May 3, 2024
* improve_functional_testing

* improve_functional_testing

* improve_functional_testing

---------

Co-authored-by: Vamshi Kolanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants