DBT-780: Upgrade dbt-core version and dbt-impala adapater version to 1.7 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshikolanu
changed the title
vamshikolanu
changed the title
|
please update the test plan and doc requirement too eg cloudera/dbt-hive#150 |
* improve_functional_testing * improve_functional_testing * improve_functional_testing --------- Co-authored-by: Vamshi Kolanu <[email protected]>
niteshy
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Upgrade dbt-core version and dbt-hive adapater version to 1.7
dbt-core has removed hologram dependency as part of this PR: https://github.com/dbt-labs/dbt-core/pull/8437/files
Hence removing it from dbt-impala too.
Internal Jira ticket number or external issue link
https://jira.cloudera.com/browse/DBT-780
Testing procedure/screenshots(if appropriate):
https://gist.github.com/vamshikolanu/f6e0c89136d34810b5dfb2b3874f956f
Checklist before requesting a review