Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-772: Upgrade dbt-impala adapter to use v1.6 dbt-core #196

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

vamshikolanu
Copy link
Collaborator

@vamshikolanu vamshikolanu commented Apr 5, 2024

Describe your changes

  1. Upgrade dbt-core to 1.6
  2. Removed support for microseconds datediff micro as Impala doesn't really support microseconds extration from timestamp.
  3. Renamed prepare-env to dev_setup in the make file to make it consistent with dbt-hive adapter.

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-772

Testing procedure/screenshots(if appropriate):

https://gist.github.com/vamshikolanu/f6f6800ce24f638d2936addf56101b82

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

Copy link
Collaborator

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things:

  1. Let's land the separate PR for dbt-core 1.5 upgrade, so that we know test fixes are required for 1.6
  2. If there are code change then let's put a separate PR so that it is easier to update the release notes.
  3. 1.6 upgrade can happen with test fixes.

tests/functional/adapter/test_utils.py Show resolved Hide resolved
@vamshikolanu vamshikolanu changed the title Upgrade dbt-impala adapter to use v1.6 dbt-core DBT-772: Upgrade dbt-impala adapter to use v1.6 dbt-core Apr 9, 2024
Copy link
Collaborator

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge 1.5 PR first, then you can merge it.

@vamshikolanu vamshikolanu merged commit 0456d0b into master Apr 9, 2024
@niteshy niteshy deleted the v1.6_impala branch May 17, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants