Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-746: Add tests for Incremental full refresh #182

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

vamshikolanu
Copy link
Collaborator

@vamshikolanu vamshikolanu commented Oct 11, 2023

Describe your changes

Adding tests for Incremental full refresh. As part of this test, Running full-refresh after ensuring incremental mode is working as expected.

Full refresh does the following:

  1. Create a temp table as the model query.
  2. Alters the main table to temp table.
  3. Alters temp table to main table.
  4. Drops the renamed main table

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-746

Testing procedure/screenshots(if appropriate):

Create table as statement:
https://gist.github.com/vamshikolanu/302bb0b7ca9efaa75fa74c9225f65b7c#file-gistfile1-txt-L980

Alter table statements:
https://gist.github.com/vamshikolanu/302bb0b7ca9efaa75fa74c9225f65b7c#file-gistfile1-txt-L1047
https://gist.github.com/vamshikolanu/302bb0b7ca9efaa75fa74c9225f65b7c#file-gistfile1-txt-L1097

Drop table statement:
https://gist.github.com/vamshikolanu/302bb0b7ca9efaa75fa74c9225f65b7c#file-gistfile1-txt-L1118

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

Copy link
Collaborator

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vamshikolanu vamshikolanu changed the title Add tests for Incremental full refresh DBT-746: Add tests for Incremental full refresh Oct 11, 2023
@vamshikolanu vamshikolanu merged commit afd51ed into master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants