DBT-698: Fixing the ParseException in UA, via removing the semicolon at the end of query #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Even though the queries ending with semicolon works for Impala without UA but they fails with ParseException in UA
Hence, removed the ending semicolon for all queries.
Internal Jira ticket number or external issue link
DBT-698
Testing procedure/screenshots(if appropriate):
Verified no regression in impala (without UA) https://gist.github.com/niteshy/9657cc0a52515e5f8f90b6f52a0e9541
Verified the ParseException is fixed, but there are SemanticException https://gist.github.com/niteshy/a01837d9dc1dbbfe760e40c6df967d9c, which is separate issue DBT-699
Checklist before requesting a review