Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-693: Pre-commit checks for code quality and syntax, for python 3.7 plus #171

Merged
merged 1 commit into from
May 5, 2023

Conversation

niteshy
Copy link
Collaborator

@niteshy niteshy commented May 5, 2023

Describe your changes

Adding a pre-commit hook for code quality, and formatting configurations. Actual formatting changes are part of #169. These are kept intentionally separate so that configuration can be easily reviewable.
Formatting the code to use Python 3.7 or higher syntax

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-693

Testing procedure/screenshots(if appropriate):

https://gist.github.com/niteshy/04e7fceeb07e06104c4bfb1ac3b055bc

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@niteshy niteshy force-pushed the precommit-config-3.7 branch from 1b1ef10 to a5c90fb Compare May 5, 2023 18:08
@niteshy niteshy force-pushed the precommit-config-3.7 branch from a5c90fb to 311b24b Compare May 5, 2023 18:13
@niteshy niteshy merged commit 9c922ed into master May 5, 2023
@niteshy niteshy deleted the precommit-config-3.7 branch May 5, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants