Fix S3 lifecycle configuration #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Follow-up to #1670 to only conditionally create S3 lifecycle blocks when a value is set for expiration, since these configurations currently only provide expiration rules and at least 1 rule is required for a configuration to be set.
Also, for convenience, this PR adds a
pre-commitGit hook that will automatically run the Terraform code formatter on every commit, which means that once enabled, this Git hook should ensure that the Terraform formatting checker in CI never fails. To install the Git hooks, use themakecommand:security considerations
None, just refactoring Terraform to make dynamic behavior work correctly