-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to list of ip cidrs to block #1613
Conversation
variable "cidr_blocks" { | ||
type = list(string) | ||
default = ["192.168.0.0/32", "192.168.0.1/32"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to set any default values. Because if we happened to not pass the real values through in CI automatically, then traffic from these default CIDRs would get blocked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point, I had these for testing but removed with a new commit
Changes proposed in this pull request:
security considerations
None, end result is the exact same acl rules just future proofing if we need to expand the list of ip cidrs