Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build csb-docproxy image with new builder image feature #151

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jameshochadel
Copy link
Contributor

Changes proposed in this pull request:

  • This change adds a new feature to the OCI build step for the internal pipeline: The ability to specify a builder image. Many docker images are built using multi-stage builds: First, a more fully-featured builder image is used to build an application; next, the build artifacts are copied to a smaller final base image.
  • The motivating use case is building a Go application related to the Cloud Service Broker. A builder step with the Go toolchain builds the application, and a final step copies the binary to our standard base image.
  • Further motivation for the builder image here: Create terraform to deploy documentation proxy product#3216 (comment)
  • Related to Create terraform to deploy documentation proxy product#3216

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Updates our standard container process. Only applies to internal pipelines.

@jameshochadel jameshochadel requested review from a team as code owners December 11, 2024 15:40
@jameshochadel jameshochadel merged commit 8c58129 into main Dec 11, 2024
@jameshochadel jameshochadel deleted the builder-image branch December 11, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants