Add USWDS identifier, edit footer #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
force-pushed
the
uswds-identifier
branch
from
ca0b880 to
0a9be1d
Compare
hursey013
previously approved these changes
Mar 12, 2024
|
|
sknep
reviewed
Mar 13, 2024
There was a problem hiding this comment.
The star was transparent; it needs to be white
sknep
reviewed
Mar 13, 2024
| <a href="https://www.usa.gov/" class="usa-link"> Visit USA.gov </a> | ||
| </div> | ||
| </section> | ||
| </div> |
There was a problem hiding this comment.
There's a small border on the top to separate it from the page background of the docs section. Feel free to add more links as you like
|
I think this is now ready to be approved! |
sknep
changed the title
hursey013
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Notes
The footer is a bit outdated in terms of both content and design and could use a quick refresh. There are good examples from other TTS sites:
I'd like to keep this PR fairly tightly scoped to getting in necessary information and marginally improved design with the notion that we can improve this more in the future (but need to get the required Identifier component in relatively quickly)
Security Considerations
None