Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages Knowledge Base Article #2470

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Pages Knowledge Base Article #2470

merged 10 commits into from
Mar 6, 2024

Conversation

Ephraim-G
Copy link
Contributor

Changes proposed in this pull request:

  • Add a new Pages Knowledge Base Article

Security Considerations

N/A

@Ephraim-G Ephraim-G requested a review from a team March 4, 2024 23:16
@Ephraim-G Ephraim-G self-assigned this Mar 4, 2024
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few copyediting suggestions.

_kbarticlespages/website-api.md Outdated Show resolved Hide resolved
_kbarticlespages/website-api.md Outdated Show resolved Hide resolved
_kbarticlespages/website-api.md Outdated Show resolved Hide resolved
_kbarticlespages/website-api.md Outdated Show resolved Hide resolved
sknep
sknep previously approved these changes Mar 6, 2024
@Ephraim-G
Copy link
Contributor Author

TY @sknep want to wait until this cloud-gov/pages-example-website-api#4 is approved/merged before posting the article and having it official. Also going to have one more commit to update the date so it can post properly.

@Ephraim-G
Copy link
Contributor Author

@sknep this is it, the final review

@Ephraim-G Ephraim-G enabled auto-merge March 6, 2024 20:25
@Ephraim-G Ephraim-G requested a review from sknep March 6, 2024 20:25
@Ephraim-G Ephraim-G added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 1d3dcdc Mar 6, 2024
4 of 6 checks passed
@Ephraim-G Ephraim-G deleted the kb-article branch March 6, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants