Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add malicious traffic protections doc #2430

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Nov 3, 2023

Closes https://github.com/cloud-gov/private/issues/882

Changes proposed in this pull request:

  • Add document on the malicious traffic protections on cloud.gov

Security Considerations

This document outlines the protections against malicious traffic built-in to the platform

add note on CDN protection against traffic surges

revise section on AWS rules
@markdboyd markdboyd requested a review from a team November 3, 2023 21:18

Furthermore, since cloud.gov is a multi-tenant platform, it experiences a variety of malicious traffic as attackers target specific customers hosted on the platform.

In order to mitigate these ongoing attacks to keep our customers' applications secure and online, cloud.gov includes a number of protections built-in to the platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this sentence because it focuses on the customer impact. What do you think about re-working the previous two paragraphs to also be from the customer point of view, instead of the platform point of view? We could explain that as a provider, we observe more diverse and frequent attacks than any single application team could see themselves, and because of this, we build strong tools to mitigate them. We could also mention that our mitigations are intended to not only protect individual tenants from attack, but also from being affected by high volumes of traffic going to other customers on the platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 9f379ca ?

@pburkholder
Copy link
Contributor

I like this. I don't want the perfect to be the enemy of the good, so I think we can publish as-is. If we have capacity, it would be good to match this up with

  • traffic flow diagrams (which exist at diagrams.fr.cloud.gov, but should be moved)
  • a news post that we now have this documentation.
  • perhaps a strong nudge to use CloudFront

@markdboyd
Copy link
Contributor Author

@pburkholder

traffic flow diagrams (which exist at diagrams.fr.cloud.gov, but should be moved)

I'm not sure how this would link up with those. But personally, I also find the diagrams at diagrams.fr.cloud.gov completely unintuitive and not something I'd generally want to surface for customers. If we did need/want some diagram for this article, I'd rather implement them in Mermaid for maintainability and intelligibility

a news post that we now have this documentation.

I tend to agree with this and it could be a follow-up PR

perhaps a strong nudge to use CloudFront

We can nudge all we want, but I think the better approach here will be updating the external-domain-service to drop the non-CDN option altogether and giving people no choice

@jameshochadel
Copy link
Contributor

FWIW I think the diagrams.fr.cloud.gov diagrams are written in Mermaid — but I agree that they're unintuitive, and I think it's because they're either too high-level for the amount of detail they contain, or too detailed for a high-level view of the system. (I think it's the latter.) (But I digress.)

@pburkholder
Copy link
Contributor

All my concerns are addressed. @jameshochadel ?

@markdboyd markdboyd added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 19ec0f8 Nov 6, 2023
1 check passed
@markdboyd markdboyd deleted the add-ddos-protection-doc branch November 6, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants