Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Single-Page-Application Pages KB Article #2428

Merged
merged 16 commits into from
Nov 9, 2023
Merged

Add Single-Page-Application Pages KB Article #2428

merged 16 commits into from
Nov 9, 2023

Conversation

Ephraim-G
Copy link
Contributor

Changes proposed in this pull request:

  • Add a Pages specific knowledge base article
  • Add an image to _assets folder

Security Considerations

N/A

svenaas
svenaas previously requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few copyediting suggestions

_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
@Ephraim-G
Copy link
Contributor Author

Thank you @svenaas

@Ephraim-G Ephraim-G changed the title WIP Add Single-Page-Application Pages KB Article (Review) Add Single-Page-Application Pages KB Article Nov 8, 2023
@Ephraim-G Ephraim-G requested a review from a team November 8, 2023 14:55
drewbo
drewbo requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small header changes, otherwise good to go

_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
apburnes
apburnes reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this info together! I've got a couple of comments.

_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
_kbarticlespages/single-page-application.md Outdated Show resolved Hide resolved
@Ephraim-G Ephraim-G enabled auto-merge November 8, 2023 20:27
@Ephraim-G
Copy link
Contributor Author

@apburnes ready for final approval

@Ephraim-G Ephraim-G added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit ba78c41 Nov 9, 2023
1 check failed
@Ephraim-G Ephraim-G deleted the KB branch November 9, 2023 16:45
@Ephraim-G Ephraim-G mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apburnes apburnes apburnes left review comments

@drewbo drewbo drewbo approved these changes

@svenaas svenaas svenaas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ephraim-G @svenaas @apburnes @drewbo