Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #100

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Code cleanup #100

wants to merge 2 commits into from

Conversation

vlordier
Copy link

a bit of code cleanup & comments to make the code bit more accessible, no functional changes

@hafriedlander
Copy link
Collaborator

Hi @vlordier. Thanks for the PR. I see quite a few issues with the code though.

I started a review, but there's a higher level question that probably should be answered first, which is: what should the formatting standard for the project be?

I use Black + Flake8 personally, and would advocate for that to be the standard (something like https://github.com/hafriedlander/stable-diffusion-grpcserver/blob/main/.vscode/settings.json) - @cloneofsimo do you have any preferences?

@hafriedlander
Copy link
Collaborator

Oh, also, PRs should be raised against develop rather than master

@cloneofsimo cloneofsimo changed the base branch from master to develop December 30, 2022 05:29
@cloneofsimo
Copy link
Owner

Yes it seems like many differences come from formatting. I think I use black with default linebreaks but ill notify when Im home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants