Add support for ES/Shield 2.3.3 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use shield rest client in the test for rest aggregation; use shield client in rest query tests; filter out failing rest specs for shield client; fix the rest-api.delete-test; fix rest-api.get-test when indexes were missing; use shield.fixtures instead fixture namespace from Elastisch; fix rest-api index tests as dynamic index isnot default anymore; fix rest-api/bulk-test by initializing index before tests; make test for native client to run with shield client; set up Travis CI with dockerized ES; fix tab issues in travis config; add missing service to allow docker in TravisCI; cleanups; update readme and changelogs;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here's solutions for the the issue #226, which adds support for Elastic Shield.
This PR includes drop-in clients for Rest and Native transport, tests and functional configuration for TravisCI.
There are still some shortcomings:
it uses timgluz/elastisch:3.0.0-beta2 as dev dependency, which was built from the latest master branch to make all the test to work without changing tests and falling back to older rest-client;
only doc & usage example is the README;
i didn't have time to test support for SSL;
I added Makefile to make it easier to set up Elasticsearch instance with the shield support:
Have a nice holidays!