Upgrade to ruby 3 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendy-clio
force-pushed
the
upgrade_to_ruby_3
branch
from
e57c1bc to
44d2727
Compare
anthonyoconnorclio
requested review from
a team,
anthonyoconnorclio,
parsahonarmand99,
Drew-Goddyn and
peerkleio
and removed request for
a team
peerkleio
previously approved these changes
Jun 7, 2024
wendy-clio
force-pushed
the
upgrade_to_ruby_3
branch
from
44d2727 to
b01c62a
Compare
wendy-clio
commented
Jun 7, 2024
| @@ -14,8 +14,6 @@ jobs: | |||
| matrix: | |||
| gemfile: | |||
| - Gemfile | |||
| - Gemfile.5.2 | |||
There was a problem hiding this comment.
Removing CI job for unsupported rail versions.
wendy-clio
commented
Jun 7, 2024
| @@ -1,5 +1,6 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
| gem "activerecord", ">=7" | |||
| gem "sqlite3", "~> 1.4" | |||
There was a problem hiding this comment.
This is a constraint on ActiveRecord connection https://github.com/rails/rails/blob/v7.1.3.4/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
Without it, we will get higher version of sqlite3 which break the connection.
Latest beta version already fixed the problem, we just need to wait until the stable version to upgrade.
wendy-clio
requested review from
peerkleio,
apalmblad,
fimmtiu,
MrJakeReid,
tudorbertiean and
Vtown121
tudorbertiean
approved these changes
Jun 7, 2024
anthonyoconnorclio
approved these changes
Jun 7, 2024
Vtown121
approved these changes
Jun 10, 2024
wendy-clio
force-pushed
the
upgrade_to_ruby_3
branch
from
b01c62a to
9fc8289
Compare
gavingmiller
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to ruby 3.1
From another PR with a CI outcome that enables deprecation warnings, we can see that only tests with Gemfile 5.2(ActiveRecord ~>5.2) has warnings on the method within the ActiveModel gem, which comes with ActiveRecord.
After checking the ruby/rail support list, Rail version < 6.1 is no longer supported and not compatible with ruby version >= 3.0.0. So, I take this PR a chance to also remove unsupported Rail versions (5.2 & 6.0).