Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected to CLINT data repo & added plotting #10

Closed
wants to merge 13 commits into from
Closed

Conversation

mmaiergerber
Copy link
Collaborator

Additional Information

I was to fast and accidentally made my change in the main branch, but I immediately reverted it. Then I made the exact same change in the dev2 branch. This PR is now for you to review the changes. Thanks.

@mmaiergerber
Copy link
Collaborator Author

@cehbrecht This change in the code requires metview (software developed at ECMWF) to be installed for plotting purposes. May I ask you to install it for shearwater? Details can be found under: https://metview.readthedocs.io/en/latest/install.html
Many thanks!

@PaoloBonettiPolimi
Copy link
Collaborator

@cehbrecht I've tried to add the metview library requested by Michael in the environment.yaml and the requirement.txt, requirements_dev.txt as usual but I get some errors, I'll wait for you to double check it, and then I will go through the revision of the updates once the process is working.

@cehbrecht
Copy link
Contributor

cehbrecht commented Jun 17, 2024

@PaoloBonettiPolimi @mmaiergerber tests are working now :)

I switched to a "conda based build" in the tests. There was an issue with the eccodes ... maybe due to a missing env variable ... and conda might take care of it.

I have updated the requirements_dev ... we only need to add here the additional packages for testing.

I tried to get the linting fixed (pep8) and the docs build (lazy load metview). Please check it the code is still doing the right thing :)

The conda spec file is updated ... I will deploy it at the DKRZ VM.

@cehbrecht
Copy link
Contributor

cehbrecht commented Jun 17, 2024

@mmaiergerber I have deployed the dev2 branch ... but it fails with the following error:

Traceback (most recent call last):
  File "/usr/local/anaconda/envs/shearwater/lib/python3.11/site-packages/pywps/app/Process.py", line 260, in _run_process
    self.handler(wps_request, wps_response)  # the user must update the wps_response.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/anaconda/envs/shearwater/lib/python3.11/site-packages/shearwater/processes/wps_cyclone.py", line 112, in _handler
    fs1_param = mv.read(
                ^^^^^^^^
  File "/usr/local/anaconda/envs/shearwater/lib/python3.11/site-packages/metview/bindings.py", line 1286, in wrapped
    return value_from_metview(val)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/anaconda/envs/shearwater/lib/python3.11/site-packages/metview/bindings.py", line 1240, in value_from_metview
    raise retval
Exception: Metview error: Error calling Metview function

I have rolled the installation back to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants