fixing no_lag bug #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cehbrecht
approved these changes
Apr 16, 2024
|
@PaoloBonettiPolimi if you like you could add a test for it. |
|
@PaoloBonettiPolimi you can use pytest to create an temp folder for you: |
|
@cehbrecht thank you for the suggestion, I have added the test for the "no_lag" input. I have also tested the full process and it seems to work, can you update the demo after the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the bug found in the demo, where with "no_lag" setting there was an issue due to the string type, which is now converted into an integer (0) to be compliant with the other time lags.