-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dia.CellView): add unset() attribute callback #2735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynekstara
reviewed
Aug 14, 2024
zbynekstara
reviewed
Aug 14, 2024
zbynekstara
reviewed
Aug 14, 2024
zbynekstara
reviewed
Aug 14, 2024
zbynekstara
reviewed
Aug 14, 2024
kumilingus
force-pushed
the
unset-attribute
branch
from
August 14, 2024 14:41
fea5482
to
35d425f
Compare
zbynekstara
reviewed
Aug 15, 2024
zbynekstara
reviewed
Aug 15, 2024
Co-authored-by: Zbynek Stara <[email protected]>
Co-authored-by: Zbynek Stara <[email protected]>
zbynekstara
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you currently set
sourceMarker
and later try to remove it by setting it tonull
,marker-start
SVG attribute will not be removed from the DOM. This is a mechanism to ensure that the actual presentation attributes can be removed if necessary.This PR also defines TypeScript for defining custom special attributes and fixes various examples where special attributes were used.
Documentation
The
unset
callback for presentation attributes is called when an attribute is set tonull
.unset
callback defined, an attribute with the same name as attribute definition is removed.(node, attrs, cellView)
.