fix(attributes): text-wrap takes external CSS into account #2542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
text-wrap
attribute takes external CSS and inherited styles into account when computing the line breaks (previously only explicit inline attributes were considered).The
text-wrap
worked properly only when the font attributes were set explicitly.This PR adds support for external CSS:
Note: Thanks to #2459, all font attributes are evaluated and set before
text-wrap
, so it is safe to use thegetComputedStyle()
method.Fixes #2295.